[PATCH] D48754: recognize more abs pattern

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 16:19:53 PDT 2018


spatel added a comment.

For min/max, we made value tracking (matchSelectPattern) recognize more patterns:
https://reviews.llvm.org/rL286776

And then we canonicalized the IR to the most recognizable form (where the cmp operands match the select operands):
https://reviews.llvm.org/rL295758

I think that's a better solution than adding more pattern matching to the DAG. For example, this isn't going to help vector code?


https://reviews.llvm.org/D48754





More information about the llvm-commits mailing list