[PATCH] D48791: [AArch64] Implement execute-only CodeGen Support.

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 14:51:12 PDT 2018


srhines added a comment.

This is really cool. I just had one minor suggestion for testing, and will otherwise defer to the ARM64-related folks to accept the patch. The rest looks quite reasonable to me, though.



================
Comment at: test/CodeGen/AArch64/execute-only-section.ll:1
+; RUN: llc < %s -mtriple=aarch64 -mattr=+execute-only %s -o - | FileCheck %s
+
----------------
Does it make sense to have another test that runs llvm-readobj on an assembled object and verifies that these sections are indeed marked as execute-only?


Repository:
  rL LLVM

https://reviews.llvm.org/D48791





More information about the llvm-commits mailing list