[PATCH] D48054: [libFuzzer] Mutation tracking and logging implemented

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 13:18:38 PDT 2018


kcc added a comment.

add a .lit test, please



================
Comment at: FuzzerMutate.cpp:539
 
 void MutationDispatcher::AddWordToManualDictionary(const Word &W) {
+  ManualDictionary.push_back({W, std::numeric_limits<size_t>::max()});
----------------
still an unrelated change? 


================
Comment at: FuzzerMutate.h:98
 
+private:
   size_t AddWordFromDictionary(Dictionary &D, uint8_t *Data, size_t Size,
----------------
do you still need to move "private:"


================
Comment at: FuzzerMutate.h:134
 
   Vector<Mutator> CurrentMutatorSequence;
   Vector<DictionaryEntry *> CurrentDictionaryEntrySequence;
----------------
Now that you have CurrentMutatorIdxSequence you probably can get rid of CurrentMutatorSequence


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48054





More information about the llvm-commits mailing list