[PATCH] D48054: [libFuzzer] Mutation tracking and logging implemented

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 11:38:46 PDT 2018


kcc added a comment.

the current patch is hard to review as it contains tons of formatting (or otherwise unrelated) fixed. 
Plz don't mix formatting/refactoring with meaningful changes in one patch.



================
Comment at: FuzzerDefs.h:19
 #include <cstring>
+#include <memory>
+#include <set>
----------------
plz don't include unrelated changes, they make the review harder. 


================
Comment at: FuzzerMutate.cpp:68
 static char RandCh(Random &Rand) {
-  if (Rand.RandBool()) return Rand(256);
+  if (Rand.RandBool())
+    return Rand(256);
----------------
again, don;t include unrelated changes. 
here and below. 


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48054





More information about the llvm-commits mailing list