[PATCH] D48413: [llvm-objcopy] Add initial support for static libraries

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/basic-archive-copy.test:9
+# RUN: llvm-ar p %t2.a > %t3
+# RUN: cmp %t2 %t3
+
----------------
jhenderson wrote:
> alexshap wrote:
> > jakehehrlich wrote:
> > > For a multi object target it would be cool to build the archive two ways. 1) un-objcopied bins -> archive -> copied archive and 2) objcopy the binaries -> archive and then check that those files are the same. 
> > the archive files won't be the same since they internally contain the names of the files.
> You could move them to some common name before adding them to the archive maybe?
I added a test for multiple files to strip-debug.test because there the object files are getting meaningfully modified, I felt it was better. Instead of comparing the archive files (for the reason mentioned above) I compared the dumps (yes, moving files before putting into archive is also an option, though i'm not a big fan of it, using dumps seems to be better).


Repository:
  rL LLVM

https://reviews.llvm.org/D48413