[PATCH] D48662: [InstCombine] reverse canonicalization of binops to allow more shuffle folding

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 10:29:36 PDT 2018


spatel updated this revision to Diff 153526.
spatel marked 2 inline comments as done.
spatel added a comment.

Patch updated - no functional changes from the last rev, but:

1. Add a "operator bool()" to make the code cleaner.
2. Assert that operand 1 of the alternate binop is a constant (might change as we add more cases).
3. Improve formula in code comment with parens.


https://reviews.llvm.org/D48662

Files:
  lib/Transforms/InstCombine/InstCombineVectorOps.cpp
  test/Transforms/InstCombine/shuffle_select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48662.153526.patch
Type: text/x-patch
Size: 7521 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180629/0f8d0911/attachment.bin>


More information about the llvm-commits mailing list