[PATCH] D48723: Fix IRPrinting bug

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 10:18:34 PDT 2018


dexonsmith added a comment.



In https://reviews.llvm.org/D48723#1147935, @tyb0807 wrote:

> No don't get me wrong, this patch is supposed to fix the issue in the `LegacyPassManager`, and I do not intend to change anything about the new pass manager in this patch.
>
> As to implementing `print-after-all` in the new pass manager, I do not know what should be the best way to do yet... Your idea seems to be a good solution.


I think it would be oddly divergent if these are analyses in one pass manager and not the other, which is why I'm pushing to understand what we'll do for both.



================
Comment at: test/Other/printer.ll:10
+
+;CHECK-NOT: IR Dump After Print Module IR
----------------
Can you add a positive check that Print Module IR is actually being called?


https://reviews.llvm.org/D48723





More information about the llvm-commits mailing list