[PATCH] D48765: [X86] The TEST instruction is eliminated when BSF/TZCNT is used

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 10:07:43 PDT 2018


craig.topper added a comment.

I need to look at this in more detail, but does this handle the case where the flags are still live past the cmov? Moving the add down would break that.

I wonder if we can just fix this pattern as a dag combine on the CMOV node before isel? That should be a lot simpler.


Repository:
  rL LLVM

https://reviews.llvm.org/D48765





More information about the llvm-commits mailing list