[PATCH] D48771: [ELF] Don't create empty output section for unreferenced PROVIDE symbol

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/LinkerScript.cpp:841
+      // symbols.
+      if (Cmd->Provide)
+        continue;
----------------
jhenderson wrote:
> grimar wrote:
> > I also was wondered if we might want to abstract from `Provide` here and use something like
> > 
> > ```
> > if (Cmd->Name != "." && !Cmd->Sym)
> > ...
> > ```
> > 
> > But I am not sure it worth doing.
> My one concern with this change is that it relies on us setting Provide to false when we define a symbol because of it. I'll try with your suggested change on Monday before putting this in, as I think it feels a little safer. Are you happy with it going straight in if I make that change?
Yep.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48771