[PATCH] D48763: [SimplifyIndVar] Canonicalize comparisons to unsigned while eliminating truncs

[David Greene via Phabricator via llvm-commits]

greened added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyIndVar.cpp:558
 
+  auto HighestBitsMatch = [&](Value *X, Value *Y) {
+    const SCEV *SCEVX = SE->getSCEV(X);
----------------
That name seems misleading.  It's not checking if they match, it's checking if the higest bit is zero for both.  Did you mean to add a check for both being negative as well?  The comments below seem to indicate so.


https://reviews.llvm.org/D48763