[PATCH] D48723: Fix IRPrinting bug

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 17:51:56 PDT 2018


dexonsmith added a comment.

I'm not sure this technique will work in the new pass manager, since analyses are run on-demand IIRC.  I wonder if it would be better to leave these as passes, and implement `-print-after-all` by inserting `-print-module`/etc. passes into the pipeline as the pipeline is being constructed.  You could avoid adding extra `-print-module` statements in cases where that pass already exists.

In any case you'll need a test for what you have changed.


Repository:
  rL LLVM

https://reviews.llvm.org/D48723





More information about the llvm-commits mailing list