[PATCH] D48744: [WebAssembly] Remove ELF file support.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added a comment.

So much red, so pretty!



================
Comment at: lib/MC/MCParser/AsmParser.cpp:700
+    // same for now.
     PlatformParser.reset(createELFAsmParser());
     break;
----------------
This one should be renamed, since there is now only one MCAsmParserExtension for wasm, and its implementation is actually kinda ELF-y, but it is wha we'll use for wasm mode going forward.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:188
 
-void WebAssemblyAsmPrinter::EmitFunctionBodyEnd() {
-  if (TM.getTargetTriple().isOSBinFormatELF())
----------------
does it make sense to keep an empty function here for wasm functionality?


================
Comment at: test/CodeGen/WebAssembly/negative-base-reg.ll:13
 ; longer be useful as written.
-; CHECK: i32.const $0=, -128
+; CHECK: i32.const $push{{[0-9]+}}=, -128
 entry:
----------------
this I don't understand, how does your change affect it being written to a local or the stack?


Repository:
  rL LLVM

https://reviews.llvm.org/D48744