[llvm] r335915 - Fix padding with custom character in formatv.

Friedman, Eli via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 14:16:11 PDT 2018


Both git and svn commit messages are UTF-8, so probably something 
happened on your computer.  Maybe a bug in the version of git-svn you're 
using?

-Eli

On 6/28/2018 2:02 PM, Zachary Turner wrote:
> That's odd.  I went here (https://reviews.llvm.org/p/mkoeppen/), 
> Ctrl+C'ed on his name, Ctrl+V'ed into the git commit window, and then 
> submit.  After committing, when I did git log it showed up correctly 
> for me.  I guess it got munged somewhere between git, svn, and the 
> master repository.
>
> On Thu, Jun 28, 2018 at 2:00 PM Friedman, Eli <efriedma at codeaurora.org 
> <mailto:efriedma at codeaurora.org>> wrote:
>
>     On 6/28/2018 1:09 PM, Zachary Turner via llvm-commits wrote:
>     > Author: zturner
>     > Date: Thu Jun 28 13:09:37 2018
>     > New Revision: 335915
>     >
>     > URL: http://llvm.org/viewvc/llvm-project?rev=335915&view=rev
>     > Log:
>     > Fix padding with custom character in formatv.
>     >
>     > The format string for formatv allows to specify a custom padding
>     > character instead of the default space.  This custom character was
>     > parsed correctly, but not passed on to the formatter.
>     >
>     > Patch by Marcel Köppe
>
>     I assume that's supposed to be "Marcel Köppen".
>
>     I'm curious, how did you manage to get "Köppe" into the commit
>     message?  It looks like UTF-8 text was incorrectly interpreted as
>     windows-1252 in at least two separate places.
>
>     -Eli
>
>     -- 
>     Employee of Qualcomm Innovation Center, Inc.
>     Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>     a Linux Foundation Collaborative Project
>

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180628/c3dd5fa0/attachment.html>


More information about the llvm-commits mailing list