[PATCH] D48676: [Local] Teach insertReplacementDbgValues basic integer/pointer conversions

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 14:12:13 PDT 2018


dblaikie added subscribers: vsk, dblaikie.
dblaikie added a comment.

Side note: please don't depend on what type a pointer points to, if
possible (& it should be possible everywhere except where necessary to
match the IR  constraints - eg: you may need to check a pointer's pointee
type to ensure a use of a value of that type matches up with its
definition). Eventually pointee types will go away & someone will have to
fix up that code... best to avoid that if we can.


https://reviews.llvm.org/D48676





More information about the llvm-commits mailing list