[PATCH] D47919: llvm-readobj: add experimental support for SHT_RELR sections.
Rahul Chaudhry via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 28 13:29:54 PDT 2018
rahulchaudhry marked an inline comment as done.
rahulchaudhry added a comment.
> LGTM, sorry for the back and forth!
Thanks for the review.
Specifically, thanks for insisting that printRelocation() should only be called for real relocations, and not for printing RELR entries with a fake relocation name. I think we ended up with both cleaner code and cleaner output as a result.
If everything looks good, can you land this as well. I don't have commit access.
Repository:
rL LLVM
https://reviews.llvm.org/D47919
More information about the llvm-commits
mailing list