[PATCH] D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling()

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 12:35:39 PDT 2018


echristo added a comment.

Looking pretty good at this point. I am still curious why we've got the scheduling change here...



================
Comment at: lib/Target/PowerPC/PPCSubtarget.cpp:189-190
                                        unsigned NumRegionInstrs) const {
-  if (needsAggressiveScheduling(DarwinDirective)) {
-    Policy.OnlyTopDown = false;
-    Policy.OnlyBottomUp = false;
-  }
+  Policy.OnlyTopDown = false;
+  Policy.OnlyBottomUp = false;
 
----------------
echristo wrote:
> echristo wrote:
> > These appear to be the defaults?
> We should probably comment on why we do this?
I do wonder "why" we want to do this rather than just that we're doing it.


https://reviews.llvm.org/D48663





More information about the llvm-commits mailing list