[PATCH] D48619: [X86] Limit the number of target specific nodes emitted in LowerShiftParts

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 12:23:41 PDT 2018


craig.topper added inline comments.


================
Comment at: test/CodeGen/X86/legalize-shift-64.ll:146
+; CHECK-NEXT:    xorl %eax, %eax
+; CHECK-NEXT:    orl $0, %eax
+; CHECK-NEXT:    je .LBB5_3
----------------
RKSimon wrote:
> ?
I didn't look closely at it. I'm assuming we're missing constant folding on X86ISD::OR.

Notice in the LHS side we do the equally dumb

```
movb $32, %dl
testb %dl, %dl
jne
```


https://reviews.llvm.org/D48619





More information about the llvm-commits mailing list