[PATCH] D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: lib/CodeGen/TargetPassConfig.cpp:121
+                          "Run on all functions guaranteed to be beneficial "
+                          "(pass -enable-linkonceodr-outlining for more)"),
+               clEnumValN(NeverOutline, "never", "Disable all outlining"),
----------------
paquette wrote:
> javed.absar wrote:
> > "linkonceodr" - is it a typo? not sure how to read this
> The intention was to say "I would also like to outline from functions with linkonceodr linkage", which the outliner doesn't do by default. I'm open to changing this if it's confusing though. Any thoughts?
Actually, I see why this is confusing. I'll just remove the note since it's kind of misleading.


https://reviews.llvm.org/D48682