[PATCH] D46365: AMDGPU: Separate R600 and GCN TableGen files

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 09:19:12 PDT 2018


tstellar added inline comments.


================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:735-739
 unsigned getMCReg(unsigned Reg, const MCSubtargetInfo &STI) {
+  if (STI.getTargetTriple().getArch() == Triple::r600)
+    return Reg;
   MAP_REG2REG
 }
----------------
arsenm wrote:
> I would expect this to be a separate function, but not sure where this would go
We can refactor AMDGPUMCInstLower.cpp so that this can be in its own function.  I can work on this as one of the follow on clean ups.


Repository:
  rL LLVM

https://reviews.llvm.org/D46365





More information about the llvm-commits mailing list