[PATCH] D48541: [Function] Use deterministic IDs when mangling unnamed types.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 08:09:56 PDT 2018


fhahn added a comment.

In https://reviews.llvm.org/D48541#1145433, @efriedma wrote:

> Maybe we could set names for the types in question?  It's kind of awkward, but it should work, I think...
>
> Alternatively, you could avoid generating ssa_copy calls which require mangling non-literal structs; assuming you don't need to ssa_copy first-class aggregates, struct types only show up in pointers, and you can always bitcast pointers to i8*.


Thanks! I think I'll try to go with that approach for now, as it seems to have a much smaller impact. "All" that should be needed is teaching PredicateInfo's users to look through bitcasts in such cases I think.


https://reviews.llvm.org/D48541





More information about the llvm-commits mailing list