[PATCH] D48678: [InstCombine] enhance shuffle-of-binops to allow different variable ops (PR37806)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineVectorOps.cpp:1186
+    // shuffle (op C0, X), (op C1, Y), M --> op C', (shuffle X, Y, M)
+    V = Builder.CreateShuffleVector(X, Y, Shuf.getMask());
+  else
----------------
lebedev.ri wrote:
> What about `getSafeVectorConstantForIntDivRem()`?
We still call that below here, and the translation from undef to 1 is covered by the "srem_2_vars" test. 

Am I understanding the question?


https://reviews.llvm.org/D48678