[PATCH] D47930: Make email options of find_interesting_reviews more flexible.

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls marked 2 inline comments as done.
kristof.beyls added inline comments.


================
Comment at: utils/Reviewing/find_interesting_reviews.py:591
+        default="",
+        help="A comma separated list of email addresses to send the report to.")
+    parser.add_argument(
----------------
JDevlieghere wrote:
> philip.pfaffe wrote:
> > Instead of taking and parsing comma separated values, why not use `nargs='+'`.
> > 
> > On the other hand, it'd be nice to rename the option to '--email-report', which optionally takes email addresses. If none are given, just send it to the email addresses passed to the `email_addresses` option.
> +1
Thanks for those suggestions, @philip.pfaffe ! I've also taken your suggestion to rename the option to '--email-report', but went for "When the --email-report flag is not specified, do not send out any emails", to make sure it remains possible to run the script and get a report without sending it over email.


https://reviews.llvm.org/D47930