[PATCH] D48413: [llvm-objcopy] Add initial support for static libraries

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 05:54:02 PDT 2018


alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/Object.h:160
+
+class MemBuffer : public Buffer {
+  std::unique_ptr<WritableMemoryBuffer> Out;
----------------
jhenderson wrote:
> I think you should just call this "MemoryBuffer" if that name doesn't clash with anything already.
it clashes with http://llvm.org/doxygen/classllvm_1_1MemoryBuffer.html. Imo the organization of the namespace needs to be fixed  (i think it would be better to move llvm-objcopy's internals into the namespace llvm::objcopy (+ add missing "static" in many places + make use of the anonymous namespace where it's appropriate), but this stuff is unrelated to my changes (and has been an issue from the early beginning (even before i started working on llvm-objcopy)) - so if i have time I'll probably try to fix it in a separate patch


Repository:
  rL LLVM

https://reviews.llvm.org/D48413





More information about the llvm-commits mailing list