[PATCH] D48577: [llvm-ar] Correct help text

[ben via Phabricator via llvm-commits]

bd1976llvm marked 2 inline comments as done.
bd1976llvm added inline comments.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:68
 
-  This program archives bitcode files into single libraries
+  This program is similar to the common Unix utility, ar. 
+  It archives several files together into a single file.
----------------
ruiu wrote:
> llvm-ar is not only similar but is actually an ar command, no?
I removed the description entirely.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:72
+USAGE: llvm-ar [options] [-]<operation>[modifiers] [relpos] <archive> [files]
+       llvm-ar -M [<mri-script]
 
----------------
ruiu wrote:
> Half-open `<`.
This is a convention used in the gnu tools help text. It is mean't to convey that if invoked with just -M then the program enters an interactive mode where you enter the script line by line but if you pipe in a script then the program reads the script non-interactively. See: https://sourceware.org/binutils/docs/binutils/ar-scripts.html#ar-scripts. Use of MRI scripts should be rare and they are only supported for compatibility with a long defunct toolchain.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:100
+  [i] - put [files] before [relpos] (same as [b])
+  [l] - Ignored for compatibility
   [o] - preserve original dates
----------------
ruiu wrote:
> Only this line starts with an uppercase letter.
Thanks!


https://reviews.llvm.org/D48577