[PATCH] D48640: [WIP][SROA] Preserve DebugLoc when rewriting alloca partitions

[Anastasis via Phabricator via llvm-commits]

gramanas added inline comments.


================
Comment at: test/Transforms/SROA/alignment.ll:2
 ; RUN: opt < %s -sroa -S | FileCheck %s
+; RUN: opt -debugify -instcombine -sroa -S < %s | FileCheck %s -check-prefix DEBUGLOC
+
----------------
vsk wrote:
> It's OK for a change to instcombine to break the test you're adding here, e.g by disabling a combine.
> 
> Is there a test you can repurpose which doesn't rely on instcombine to hit the code path you've changed?
Yes, you are absolutely right. For some reason I thought I it was the combination of the two that caused the `-check-debugify` error. 

There are some more tests that without this patch fail to preserve the DL. Should I add DEBUGLOC tests there as well or is one enough?


Repository:
  rL LLVM

https://reviews.llvm.org/D48640