[PATCH] D48599: SCEVExpander::expandAddRecExprLiterally(): check before casting as Instruction

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 02:49:52 PDT 2018


mkazantsev added a comment.

Frankly, I don't understand why we want it to be an instruction at all. Can these methods (i.e. `hoistIVInc` and `isNormalAddRecExprPHI`) be taught to work with values? For example, if it is not an instruction then we just consider it already hoisted.


Repository:
  rL LLVM

https://reviews.llvm.org/D48599





More information about the llvm-commits mailing list