[PATCH] D48711: [AArch64] Armv8.4-A: Virtualization system registers

[Oliver Stannard via Phabricator via llvm-commits]

olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.

It would be worth clarifying in the comments and commit message that this is the "Secure EL2" extension, to avoid confusion with the "Enhanced Support for Nested Virtualization" extension, which I assume will be in a later patch.

Other than that, LGTM.



================
Comment at: test/MC/Disassembler/AArch64/armv8.4a-vir.txt:1
+# RUN: llvm-mc -triple aarch64-none-linux-gnu -mattr=+v8.4a --disassemble < %s | FileCheck %s
+
----------------
Should the file name be armv8.4a-virt.txt, for consistency with the assembly test?


https://reviews.llvm.org/D48711