[PATCH] D48693: [WebAssembly] LTO: Fix signatures of bitcode symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: wasm/Driver.cpp:260-261
     // added via "--undefined"), but weak undefined ones do have a signature.
-    assert(FuncSym->getFunctionType());
-    const WasmSignature &Sig = *FuncSym->getFunctionType();
+    assert(FuncSym->FunctionType);
+    const WasmSignature &Sig = *FuncSym->FunctionType;
 
----------------
Do you need this assert? I think if it is a nullptr, it will crash immediately on the next line, so that assert() doesn't seem that useful.


================
Comment at: wasm/Symbols.h:130
+  const WasmSignature *FunctionType;
 protected:
   FunctionSymbol(StringRef Name, Kind K, uint32_t Flags, InputFile *F,
----------------
nit: insert a blank line before "protected:".


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48693