[PATCH] D48627: [ImplicitNullChecks] Check for rewrite of register used in 'test' instruction

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

Test, actually can be simplified  bit if you do not mind.



================
Comment at: test/CodeGen/X86/implicit-null-chk-reg-rewrite.mir:49
+
+    $rax = MOV64ri 2200000
+    $rax = AND64rm killed $rax, killed $rdi, 1, $noreg, 0, $noreg, implicit-def dead $eflags
----------------
Why do you need this?


================
Comment at: test/CodeGen/X86/implicit-null-chk-reg-rewrite.mir:51
+    $rax = AND64rm killed $rax, killed $rdi, 1, $noreg, 0, $noreg, implicit-def dead $eflags
+    CMP64rr killed $rax, killed $rsi, implicit-def $eflags
+    JE_1 %bb.4, implicit $eflags
----------------
I guess you do not need this CMP for reproducing the failure? just return result of the and will be enough?
Do I miss anything?


Repository:
  rL LLVM

https://reviews.llvm.org/D48627