[PATCH] D46365: AMDGPU: Separate R600 and GCN TableGen files

Wed Jun 27 20:55:43 PDT 2018

tstellar added a comment.

In https://reviews.llvm.org/D46365#1146123, @jvesely wrote:

> In https://reviews.llvm.org/D46365#1146098, @jvesely wrote:
>
> > Fails to build:
> >  llvm-tblgen: Unknown command line argument '-gen-tgt-intrinsic'.  Try: '../../../bin/llvm-tblgen -help'
> >  llvm-tblgen: Did you mean '-gen-tgt-intrinsic-impl'?
> >  make[2]: *** [lib/Target/AMDGPU/CMakeFiles/AMDGPUCommonTableGen.dir/build.make:1730: lib/Target/AMDGPU/R600GenIntrinsics.inc.tmp] Error 1
>
>
> After fixing the build file as tblgen suggested (and few local fixes in my own patches) it builds OK and there are no piglit regressions on my turks.

IntrinsicInfo isn't needed any more, so I dropped this.

> I think this should land rather soon, with a bunch of cleanup follow ups. Having things (files, classes) that are prefixed R600, AMDGPU, AMDGPUCommon, GCN, AMDGCN, and SI is rather confusing.

Ok, I can start working on this once this patch lands.

Repository:
  rL LLVM

https://reviews.llvm.org/D46365