[PATCH] D48610: [ARM] Add missing Thumb2 assembler diagnostics.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6405
   case ARM::STRD: {
-    // Rt2 must be Rt + 1.
     unsigned Rt = MRI->getEncodingValue(Inst.getOperand(0).getReg());
     unsigned Rt2 = MRI->getEncodingValue(Inst.getOperand(1).getReg());
----------------
SjoerdMeijer wrote:
> Nit: all these cases are all so similar, and differ only in a few constants. While you're at it, do you think these patterns can be factored out? 
Maybe I can factor out the LDRD/STRD cases, specifically... something like `bool ValidateLDRDSTRD(const MCInst &Inst, bool Load, bool ARMMode, bool Increment)`?


Repository:
  rL LLVM

https://reviews.llvm.org/D48610