[PATCH] D48622: [llvm-objdump] Add -x --all-headers options

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In https://reviews.llvm.org/D48622#1145608, @paulsemel wrote:

> In https://reviews.llvm.org/D48622#1145147, @MaskRay wrote:
>
> > In https://reviews.llvm.org/D48622#1144670, @paulsemel wrote:
> >
> > > It seems to be displaying the correct information.
> > >  I just noticed that we are not printing dynamic section in the `-private-headers` option, this might somehow be fixed.
> > >
> > > LGTM, but please, wait for @echristo  approval :)
> >
> >
> > We also lack `-a` (`--archive-headers`) and `-f` (`--file-headers`) :)
>
>
> That's right, I will take a look at it when I have more time, thanks a lot ! :)


And FYI https://lists.freebsd.org/pipermail/freebsd-toolchain/2018-June/003809.html FreeBSD devs are moving away from GNU binutils and migrating to LLVM counterparts. They are beneficiaries of your work :)


Repository:
  rL LLVM

https://reviews.llvm.org/D48622