[PATCH] D48394: [WebAssembly] Error on mismatched function signature in final output

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In https://reviews.llvm.org/D48394#1144482, @ruiu wrote:

> I'm not sure if this is a good thing to do, because my understanding is that -gc-sections shouldn't generally change the linking semantics except it will produce a smaller binary. With this change, you are now easy to write code that links only when you pass -gc-sections. This is perhaps not problematic for wasm because -gc-section is on by default, but still, I feel like -gc-sections shouldn't do anything more than reducing the output size. What do you think?


Hmm.. I tend to agree.  I'm working on some changes that should hopefully make these error less common, and then we should be able to turn it for all functions (even those that get GC'd)


Repository:
  rL LLVM

https://reviews.llvm.org/D48394