[PATCH] D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

In https://reviews.llvm.org/D47655#1144273, @efriedma wrote:

> Nevermind, the issue is my fault; should be `(MachineBasicBlock::reverse_iterator)front()`, not `++(MachineBasicBlock::reverse_iterator)front()`.  The resulting issue is tricky to debug because MachineInstrs are a circular linked list.


Ah, okay, I'll update the patch with that in a second.

In https://reviews.llvm.org/D47655#1144262, @efriedma wrote:

> Your results weren't making any sense, so I started debugging a bit... it looks like somehow the mechanism for removing candidates is broken.


Even though this wasn't the issue, I think that I ought to go back and refactor/rewrite the candidate removal mechanism anyway. It's pretty messy, and clearly a source of confusion. I'll start poking at that.


https://reviews.llvm.org/D47655