[PATCH] D48647: [dsymutil] Detangle DwarfLinker and move abstractions in their own implementation (NFC)
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 27 08:32:13 PDT 2018
aprantl added a comment.
Assuming there are no other code changes, this seems like a good idea.
================
Comment at: llvm/tools/dsymutil/DeclContext.cpp:3
+//
+// The LLVM Linker
+//
----------------
this comment seems wrong?
================
Comment at: llvm/tools/dsymutil/DeclContext.h:3
+//
+// The LLVM Linker
+//
----------------
this comment seems wrong?
================
Comment at: llvm/tools/dsymutil/DwarfStreamer.h:1
+//===- tools/dsymutil/DwarfLinker.h - Dwarf Streamer ------------*- C++ -*-===//
+//
----------------
DwarfStreamer?
================
Comment at: llvm/tools/dsymutil/LinkUtils.h:1
+//===- tools/dsymutil/LinkOptions.h - Dwarf debug link options --*- C++ -*-===//
+//
----------------
LinkUtils.
================
Comment at: llvm/tools/dsymutil/MachOUtils.cpp:1
//===-- MachOUtils.h - Mach-o specific helpers for dsymutil --------------===//
//
----------------
`-*- C++ -*-`
Repository:
rL LLVM
https://reviews.llvm.org/D48647
More information about the llvm-commits
mailing list