[PATCH] D48468: [SelectionDAG] Remove debug locations from ConstantSD(FP)Nodes

[Vedant Kumar via llvm-commits]

Hi Yvan,

I'll take a look now.

vedant

> On Jun 27, 2018, at 2:30 AM, Yvan Roux <yvan.roux at linaro.org> wrote:
> 
> Hi Vedant,
> 
> This patch broke ARM bots since expected line info is missing in
> address sanitizer output for null_redef.cc <http://null_redef.cc/> testcase, notice that when
> the test is compiled in thumb mode the line info is still present.
> 
> logs available at:
> 
> http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/1203/steps/ninja%20check%201/logs/FAIL%3A%20AddressSanitizer-armhf-linux%3A%3Anull_deref.cc <http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/1203/steps/ninja%20check%201/logs/FAIL:%20AddressSanitizer-armhf-linux::null_deref.cc>
> 
> Thanks
> Yvan
> 
> On Mon, 25 Jun 2018 at 19:11, Phabricator via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> 
>> This revision was automatically updated to reflect the committed changes.
>> Closed by commit rL335497: [SelectionDAG] Remove debug locations from ConstantSD(FP)Nodes (authored by vedantk, committed by ).
>> 
>> Changed prior to commit:
>>  https://reviews.llvm.org/D48468?vs=152419&id=152717#toc
>> 
>> Repository:
>>  rL LLVM
>> 
>> https://reviews.llvm.org/D48468
>> 
>> Files:
>>  llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h
>>  llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
>>  llvm/trunk/test/CodeGen/AArch64/machine-outliner-remarks.ll
>>  llvm/trunk/test/DebugInfo/ARM/single-constant-use-preserves-dbgloc.ll
>>  llvm/trunk/test/DebugInfo/Generic/constant-sdnodes-have-dbg-location.ll
>>  llvm/trunk/test/DebugInfo/Generic/constantfp-sdnodes-have-dbg-location.ll
>>  llvm/trunk/test/tools/llvm-objdump/AMDGPU/source-lines.ll
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180627/945723ce/attachment.html>