[PATCH] D48592: [llvm-exegesis] Add partial X87 support.

[Clement Courbet via Phabricator via llvm-commits]

courbet marked 2 inline comments as done.
courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Latency.cpp:92
   }
+  llvm::consumeError(SelfAliasingPrototype.takeError());
+  // No self aliasing, trying to create a dependency through another opcode.
----------------
gchatelet wrote:
> this is not needed it you use the llvm idiom
> ```
> if(auto SelfAliasingPrototype = generateSelfAliasingPrototype(Instr)) {
>    return SelfAliasingPrototype;
> }
> ```
Unfortunately this does not work as is leaves the error unchecked.


Repository:
  rL LLVM

https://reviews.llvm.org/D48592