[PATCH] D47681: [DAGCombiner] Bug 31275- Extract a shift from a constant mul or udiv if a rotate can be formed

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/rotate-extract.ll:10
+; with one of the shifts from the rotate idiom
+
+define i64 @rolq_extract_shl(i64 %i) nounwind {
----------------
Please can you add tests for a mixture of i8, i16, i32 and i64 integers - no need for duplication of all these tests just have decent range.

Ideally we'd include some vector tests as well, possibly in a separate test file.


https://reviews.llvm.org/D47681