[PATCH] D48584: [InstCombine] Delay foldICmpUsingKnownBits until simple transforms are done

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 02:01:08 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:4710-4711
+  // passes, so we use it as the last resort if we cannot do anything better.
+  if (Instruction *Res = foldICmpUsingKnownBits(I))
+    return Res;
+
----------------
Please check that there is some test that relies on this, and does not get folded by previous cases.


https://reviews.llvm.org/D48584





More information about the llvm-commits mailing list