[PATCH] D48624: [NFC][SelectionDAG] Extending Load width reduction tests to Load and Store

[Sam Parker via Phabricator via llvm-commits]

samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

LGTM with the one inline comment, please change before committing but no need to re-review.

cheers!



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4019
+    // TODO: It would be possible to merge the extensions in some cases.
+    if ((StrictInside || Load->getExtensionType() != ISD::NON_EXTLOAD) &&
+        Load->getMemoryVT().getSizeInBits() < MemVT.getSizeInBits() + ShAmt)
----------------
For this refactor, its best for StrictInside to be removed and then add it to the (I presume following) patch that uses it.


Repository:
  rL LLVM

https://reviews.llvm.org/D48624