[PATCH] D44780: [ELF] - Implement linker script OVERLAYs.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: ELF/ScriptParser.cpp:474
+  // Here we want to create the Dot assignment command to achieve that.
+  Expr MoveDotExpr = [=] {
+    uint64_t MaxSize = 0;
----------------
Maybe `MoveDot` should suffice as the variable has a very narrow scope.


================
Comment at: ELF/ScriptParser.cpp:475
+  Expr MoveDotExpr = [=] {
+    uint64_t MaxSize = 0;
+    for (BaseCommand *Cmd : V)
----------------
LIkewise, Max would suffice.


================
Comment at: ELF/Writer.cpp:2104
+static void checkOverlap(StringRef Name, std::vector<SectionOffset> &Sections,
+                         bool IsVirtualAddresses) {
   llvm::sort(Sections.begin(), Sections.end(),
----------------
IsVirtualAddr


https://reviews.llvm.org/D44780