[PATCH] D44780: [ELF] - Implement linker script OVERLAYs.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 21:56:11 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:463
+    if (Prev)
+      OS->LMAExpr = [=] { return Prev->getLMA() + Prev->Size; };
+    else
----------------
grimar wrote:
> ruiu wrote:
> > Can't you use the same `LMAExpr` again?
> Sorry, I did not understand what was your suggestion about using `LMAExpr` here?
Maybe it's not just doable, but what I was wondering was whether you could repalce this line with `OS->LMAExpr = LMAExpr` or not.


https://reviews.llvm.org/D44780





More information about the llvm-commits mailing list