[PATCH] D45604: Support for multiarch runtimes layout
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 26 19:37:04 PDT 2018
phosek added a comment.
In https://reviews.llvm.org/D45604#1141891, @Hahnfeld wrote:
> Should `ENABLE_PER_TARGET_RUNTIME_DIR` be declared at LLVM's top level `CMakeLists.txt`? If I read the patch correctly, it's in `clang` so `llvm/runtimes/` relies on the default value being `OFF` (hard to tell because the patch doesn't follow the current layout of the SVN repository but rather a git monorepo?)
I'm fine moving that option to LLVM's `CMakeLists.txt`, it's more specific to Clang which is why I defined it in Clang's `CMakeLists.txt`, but it's also needed by all runtimes so LLVM's `CMakeLists.txt` is probably more appropriate.
Repository:
rL LLVM
https://reviews.llvm.org/D45604
More information about the llvm-commits
mailing list