[PATCH] D48483: [Power9] [LLVM] Add __float128 support for trunc to double round to odd

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 11:33:42 PDT 2018


lei accepted this revision.
lei added a comment.
This revision is now accepted and ready to land.

LGTM. Please feel free to fix the nit comments before committing.



================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2570
+                                        (int_ppc_truncf128_round_to_odd
+                                        f128:$vB))]>;
 
----------------
nit: indent

```
[(set f64:$vT,
      (int_ppc_truncf128_round_to_odd
        f128:$vB))]>;
```


================
Comment at: test/CodeGen/PowerPC/builtins-ppc-p9-f128.ll:146
+  ; CHECK-LABEL: testTruncOdd
+  ; CHECK: xscvqpdpo
+}
----------------
register?


https://reviews.llvm.org/D48483





More information about the llvm-commits mailing list