[PATCH] D48490: [NFC][x86][AArch64] Add BEXTR-like test patterns.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 10:50:44 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D48490#1143767, @RKSimon wrote:

> The X86 prefix changes LGTM if you want to commit that separately and leave this patch for just the arm guys to review


Thanks, i will commit the `test/CodeGen/X86/extract-lowbits.ll` part.

I'm honestly not sure about the `test/CodeGen/*/extract-bits.ll`, 
we'd only need it if we want to actually let the `BEXTR` do the `LSHR`'s work, too.
Or at least maybe the `*_skipextrauses()` tests aren't needed..


Repository:
  rL LLVM

https://reviews.llvm.org/D48490





More information about the llvm-commits mailing list