[PATCH] D48241: [DebugInfo] Emit ObjC methods as part of interface.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+    // Add methods to interface.
+    for (auto p : ObjCMethodCache) {
+      if (p.second.empty())
----------------
dexonsmith wrote:
> Some comment for "p" here.
Fixed; I'll update the rest of the file in a follow-up to keep things consistent.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4246
+      if (it == TypeCache.end())
+        continue;
+
----------------
aprantl wrote:
> What does it mean that a type is not being found in the cache here?
Replaced it with an assert. 


https://reviews.llvm.org/D48241