[PATCH] D47540: [lld] Enable Visual Studio compatible output
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 26 07:48:54 PDT 2018
ikudrin added a comment.
@chrisjackson,
I think we need to see the other places converted, too. Reports for duplicate symbols and invalid relocations will probably require additional changes, which may lead to better design when we see the whole picture.
================
Comment at: ELF/InputFiles.cpp:86
+ // column information.
+ if (errorHandler().VSDiagnostics)
+ return Path.str() + " " + "(" + std::to_string(Line) + ")";
----------------
You may want to update the comments for `InputSectionBase::getSrcMsg()`.
https://reviews.llvm.org/D47540
More information about the llvm-commits
mailing list