[PATCH] D48592: [llvm-exegesis] Add partial X87 support.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/BenchmarkRunner.cpp:201
+    const Instruction &Instr,
+    const AliasingConfigurations &SelfAliasing) const {
+  SnippetPrototype Prototype;
----------------
As discussed, let's create SelfAliasing in the function so we don't rely on the caller to do the right thing.


================
Comment at: tools/llvm-exegesis/lib/Latency.cpp:94
   } else {
     return generateSelfAliasingPrototype(Instr, SelfAliasing);
   }
----------------
Let's do the following:
```
auto result = generateSelfAliasingPrototype(Instr);
if(result is ok) return result;
return generateTwoInstructionPrototype(Instr);
```


Repository:
  rL LLVM

https://reviews.llvm.org/D48592