[PATCH] D48240: Try again to implement a FIFO task queue

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 07:34:59 PDT 2018


The static_assert is in a template function though, which shouldn’t get
instantiated unless you create an instance of the class. And creating that
instance is ifdef’ed out. If it fixes it just move the ifdef up, but I’m a
bit confused.

Also i tested with msvc I guess that could be it
On Tue, Jun 26, 2018 at 7:29 AM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added a comment.
>
> In https://reviews.llvm.org/D48240#1143531, @zturner wrote:
>
> > This whole file is supposed to be ifdefed out in this case. Is it not? I
> >  definitely tested this case
>
>
> Looking at it, it seems that the code is tested out, but the #include
> isn't, and that's what errors. Maybe you tested it by reconfiguring an
> existing cmake build dir instead of using a fresh one and were led astray
> by cmake's overaggressive caching of build settings?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D48240
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180626/39ffb0d6/attachment.html>


More information about the llvm-commits mailing list