[PATCH] D48026: [ScopHelper] Provide support for recognising collective invariant loads

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

OK, this looks good! You haven't addressed Micheal's testcase yet for the invariant cascade crossing alias set boundaries. For the sake of progress IMO it's okay to leave a TODO and address it in a followup change. @Meinersbur what do you think?



================
Comment at: lib/Support/ScopHelper.cpp:453
+  // invariant; in this case: another invariant load (whether that address
+  // is also not written to has to be checked separately
+  // TODO: This only checks for a LoadInst->GetElementPtrInst->LoadInst
----------------
Unmatched parenthesis


https://reviews.llvm.org/D48026